Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BAA1F200D0B for ; Wed, 27 Sep 2017 17:19:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B92C21609EB; Wed, 27 Sep 2017 15:19:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0DC381609CA for ; Wed, 27 Sep 2017 17:19:03 +0200 (CEST) Received: (qmail 44161 invoked by uid 500); 27 Sep 2017 15:19:03 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 44145 invoked by uid 99); 27 Sep 2017 15:19:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 15:19:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BE3E21A4717 for ; Wed, 27 Sep 2017 15:19:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Wl8kwxWJkI8v for ; Wed, 27 Sep 2017 15:19:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D3D276127E for ; Wed, 27 Sep 2017 15:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5B2E7E0F88 for ; Wed, 27 Sep 2017 15:19:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5A2B5242AF for ; Wed, 27 Sep 2017 15:19:00 +0000 (UTC) Date: Wed, 27 Sep 2017 15:19:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCORE-491) BasicAsyncResponseConsumer can easily be tricked into triggering an OOME MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 27 Sep 2017 15:19:04 -0000 [ https://issues.apache.org/jira/browse/HTTPCORE-491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182726#comment-16182726 ] ASF GitHub Bot commented on HTTPCORE-491: ----------------------------------------- Github user mheemskerk closed the pull request at: https://github.com/apache/httpcomponents-core/pull/52 > BasicAsyncResponseConsumer can easily be tricked into triggering an OOME > ------------------------------------------------------------------------ > > Key: HTTPCORE-491 > URL: https://issues.apache.org/jira/browse/HTTPCORE-491 > Project: HttpComponents HttpCore > Issue Type: Bug > Components: HttpCore NIO > Affects Versions: 4.4.7 > Reporter: Michael Heemskerk > Fix For: 4.4.8 > > > When using {{BasicAsyncResponseConsumer}} to consume a response, the consumer initializes its {{SimpleInputBuffer}} with the value reported on the response's {{Content-Length}} header. > It's easy to spoof a response with a very large (but smaller than Integer.MAX_VALUE) {{Content-Length}} header and have the client pre-allocate a massive buffer, triggering an OOME. > Since {{SimpleInputBuffer}} already expands-on-demand, it would be trivial to cap the initial buffer size to some reasonable limit (256k or even 1M) -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org