hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "silver9886 (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.
Date Wed, 06 Sep 2017 14:22:00 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155424#comment-16155424
] 

silver9886 commented on HTTPCORE-488:
-------------------------------------

you are right ! your change is execlent´╝îI ignore the super constructor . The commit is perfect.

> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -------------------------------------------------------------------------
>
>                 Key: HTTPCORE-488
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-488
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 5.0-alpha4
>            Reporter: silver9886
>            Priority: Minor
>             Fix For: 5.0-beta1
>
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) != 0
then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message