hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.
Date Wed, 06 Sep 2017 07:26:00 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154927#comment-16154927
] 

ASF GitHub Bot commented on HTTPCORE-488:
-----------------------------------------

GitHub user xiaohu-zhang opened a pull request:

    https://github.com/apache/httpcomponents-core/pull/51

    Check connecttimeout when SelectionKey.OP_CONNECT event happend

    related to HTTPCORE-488
    InternalConnectChannel onTimeout should also invoke close method

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xiaohu-zhang/httpcomponents-core checkconnecttimeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcomponents-core/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit 4d7a18420cd66dd17387b845b324b241281d7fcc
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-08-29T14:11:24Z

    setting time limit on processPending methods
    
    setting time limit to avoid the SingleCoreIOReactor's time be exhausted
    and then  block the remaining work to do.

commit b6043b3aa94c65b23bb39804342a7826dc236eae
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-08-30T03:27:04Z

    Merge branch 'master' of https://github.com/apache/httpcomponents-core/commits/master

commit 6349d9223c01b9533d38a19e3100b7d1c81f5bae
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-04T10:49:58Z

    commit for merge from remove trank

commit d55b119b7fb9dffa7b74020a704265947eed1abb
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-04T11:10:24Z

    Merge branch 'master' of https://github.com/apache/httpcomponents-core into checkconnecttimeout
    
    # Conflicts:
    #	httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreIOReactor.java

commit 1f81fa7809f0f7c2af7cb1eee60447c3dc2534f0
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-04T11:21:26Z

    test commit

commit 5f0d50af647d478ac19da8790f23c5e4135cf5a3
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-04T11:24:43Z

    Revert "test commit"
    
    This reverts commit 1f81fa7809f0f7c2af7cb1eee60447c3dc2534f0.

commit c70f59c84eb5378f4d203d8c5b9cc9d301d2e86c
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-04T11:28:10Z

    Revert "Revert "test commit""
    
    This reverts commit 5f0d50af647d478ac19da8790f23c5e4135cf5a3.

commit 4c38f0560dd5f80a16816c5d8d32b89439ecec24
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-04T11:29:26Z

    test

commit 6c564282d0e77878af06729747873dbb0e373fff
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-06T03:08:07Z

    deal with connect time out
    add unit test

commit b0e26899cb39b5927b2ca5983aea4dcceeb29ce5
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-06T04:34:28Z

    modify with checkstyle

commit 3002e710b2f83b0c7f606dfb4c95ef9203fa6d9b
Author: xiaohu-zhang <silver9886@126.com>
Date:   2017-09-06T07:12:40Z

    add unrun unit test

----


> SingleCoreIOReactor.connect methods timeout parameter do not have effect.
> -------------------------------------------------------------------------
>
>                 Key: HTTPCORE-488
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-488
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 5.0-alpha4
>            Reporter: silver9886
>            Priority: Minor
>
> In my opinion , timeout parameter in connect method means connectTimeout.
> In InternalConnectChannel.onIOEvent ,if (readyOps & SelectionKey.OP_CONNECT) != 0
then the socketChannel will connect to the server.However , at this time,
> Perhaps It is connection time out already.
> So i suggest check connecttimeout at InternalConnectChannel.onIOEvent methods 
> When there is SelectionKey.OP_CONNECT event happend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message