hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-293) Provide support for non-ASCII charsets in the multipart disposition-content header
Date Sat, 30 Sep 2017 21:28:01 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187213#comment-16187213
] 

ASF GitHub Bot commented on HTTPCLIENT-293:
-------------------------------------------

Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/85
  
    @sermojohn
    I committed your changes with some modifications. I fixed multiple style check violations,
escaped non Latin chars in test cases, and redesigned your code to generate fewer intermediate
objects / garbage on the heap.
    
    Please review and close this PR. Feel free to raise another PR with follow-up changes.


> Provide support for non-ASCII charsets in the multipart disposition-content header
> ----------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-293
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-293
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 1.0 Alpha
>         Environment: Operating System: All
> Platform: All
>            Reporter: Eric Dofonsou
>            Priority: Minor
>             Fix For: 4.0 Beta 2
>
>
> Because of the the following line in getAsciiBytes 
>  data.getBytes("US-ASCII");
> The returned string is modified if has Latin Characters.
> Ex : Document non-controlé -> Document non-control?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message