hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ok2c <...@git.apache.org>
Subject [GitHub] httpcomponents-client issue #85: HTTPCLIENT-293 Fix proposal based on RFC 75...
Date Fri, 29 Sep 2017 11:25:11 GMT
Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-client/pull/85
  
    @sermojohn Do you mind making a few relatively minor changes to your patch? 
    1. Could you please keep `MinimalField` immutable and move all construction logic to `FormBodyPartBuilder`?
    2. `FormBodyPartBuildeencodeForHeader` appears to be no longer needed. It should probably
be removed.
    3. Could you please avoid different formatting of imports? You might need to tweak your
IDE settings for that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message