hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ok2c <...@git.apache.org>
Subject [GitHub] httpcomponents-client pull request #82: Fixed NPE PoolingAsyncClientConnecti...
Date Wed, 09 Aug 2017 18:32:16 GMT
Github user ok2c commented on a diff in the pull request:

    https://github.com/apache/httpcomponents-client/pull/82#discussion_r132268912
  
    --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
---
    @@ -183,6 +184,12 @@ public void execute(final Boolean result) {
     
                                     })));
                                 } else {
    +                                if (!connection.isOpen()) {
    --- End diff --
    
    The stale connection check (as an attempt to read from the socket) is only applicable
to blocking connections.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message