hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-459) Make request available to ResponseHandlers
Date Mon, 19 Jun 2017 14:04:00 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054048#comment-16054048

Oleg Kalnichevski commented on HTTPCORE-459:


Because I do not see a problem here. There are multiple ways of making request (or any other
contextual attributes) available to {{ResponseHandler}} s.


> Make request available to ResponseHandlers
> ------------------------------------------
>                 Key: HTTPCORE-459
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-459
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>    Affects Versions: 5.0-alpha3
>            Reporter: Tobias Oberlies
> We use HttpClients for a system test of a REST API. We are using ResponseHandlers to
directly convert the response entity to a data structure that is suitable for assertions.
> This works very well, except for the occasional case where the system under test responds
with an unexpected status code. In this case, the response handler throws an exception. For
a good error message, it would be useful to also include the request URL. However the request
object is not available in the ResponseHandler.handleResponse method.
> So this is a request to also make the HttpRequest object available in the ResponseHandler.handleResponse
method. This could be done by adding a getter in the HttpResponse class, or by creating a
new interface (e.g. HttpResponseHandler2) with a two-parameter handleResponse method.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message