Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Wed, 10 May 2017 08:43:04 +0000 (UTC)
From: "yair ogen (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.12913327.1447683943000.174481.1494405784468@Atlassian.JIRA>
In-Reply-To: <JIRA.12913327.1447683943000@Atlassian.JIRA>
References: <JIRA.12913327.1447683943000@Atlassian.JIRA> <JIRA.12913327.1447683943420@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HTTPCLIENT-1826) Async Builder should include
 setting a ExecutorService
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 10 May 2017 08:43:10 -0000


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004316#comment-16004316 ] 

yair ogen commented on HTTPCLIENT-1826:
---------------------------------------

oh. that's bad,

Adding API is exactly aligned with Open Close Principle.

You don't have that many implementations - do you? the PR added implementation where needed.

People do this all the time. You should never freeze an interface in the sense of forbid additions. you should prevent changing names or removing APIs. That DOES break backward compatibility.


> Async Builder should include setting a ExecutorService
> ------------------------------------------------------
>
>                 Key: HTTPCLIENT-1826
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1826
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: yair ogen
>
> Currently you only expose setting ThreadFactory. Not very useful if a user wants to send in a different thread pool altogether.
> We must have an option to pass in thread pools especially if we want this async work to co-exist in the same pool as other tasks.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org