Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 99F99200C73 for ; Wed, 10 May 2017 10:16:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 98C47160BCC; Wed, 10 May 2017 08:16:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE378160BC6 for ; Wed, 10 May 2017 10:16:08 +0200 (CEST) Received: (qmail 24627 invoked by uid 500); 10 May 2017 08:16:08 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 24616 invoked by uid 99); 10 May 2017 08:16:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 08:16:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 92D2E1A051E for ; Wed, 10 May 2017 08:16:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id R0rTope7iTfi for ; Wed, 10 May 2017 08:16:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 54E005F567 for ; Wed, 10 May 2017 08:16:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A3B20E01A8 for ; Wed, 10 May 2017 08:16:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5FAF721E0A for ; Wed, 10 May 2017 08:16:04 +0000 (UTC) Date: Wed, 10 May 2017 08:16:04 +0000 (UTC) From: "yair ogen (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1826) Async Builder should include setting a ExecutorService MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 10 May 2017 08:16:09 -0000 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004266#comment-16004266 ] yair ogen commented on HTTPCLIENT-1826: --------------------------------------- Nope - I need a hook into the reactor thread. not the main thread. My idea works (my PR that is). Your idea also works bu code duplication and double synchronize doesn't work good for me. What's wrong with my PR suggestion? > Async Builder should include setting a ExecutorService > ------------------------------------------------------ > > Key: HTTPCLIENT-1826 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1826 > Project: HttpComponents HttpClient > Issue Type: Improvement > Reporter: yair ogen > Fix For: 5.0 Alpha3 > > > Currently you only expose setting ThreadFactory. Not very useful if a user wants to send in a different thread pool altogether. > We must have an option to pass in thread pools especially if we want this async work to co-exist in the same pool as other tasks. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org