Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A31D5200C73 for ; Wed, 10 May 2017 21:07:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A1C8D160B9C; Wed, 10 May 2017 19:07:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E7EAA160B99 for ; Wed, 10 May 2017 21:07:36 +0200 (CEST) Received: (qmail 32577 invoked by uid 500); 10 May 2017 19:07:36 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 32566 invoked by uid 99); 10 May 2017 19:07:36 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 May 2017 19:07:36 +0000 Received: from [192.168.1.5] (p4FF775E0.dip0.t-ipconnect.de [79.247.117.224]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 8D4AD1A031E for ; Wed, 10 May 2017 19:07:35 +0000 (UTC) Subject: Re: Do not commit to HttpCore SVN! To: HttpComponents Project References: <1494403186.32724.4.camel@apache.org> <1494436397.15706.2.camel@apache.org> <1494442340.17351.2.camel@apache.org> From: Michael Osipov Message-ID: <737e6131-842f-6c55-1755-3d20bea95291@apache.org> Date: Wed, 10 May 2017 21:07:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1494442340.17351.2.camel@apache.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit archived-at: Wed, 10 May 2017 19:07:37 -0000 Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: > On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: >> On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski >> >> wrote: >> >>> ... >>> >>> >>>>> One personal request. Do you think you could try to make your >>>>> commits >>>>> less granular and combine logically related changes into larger >>>>> change >>>>> sets? >>>>> >>>> >>>> Old habits die hard. Git might indeed make this better. If you >>>> want >>>> to add >>>> this to the style guideline on the site, it will help all >>>> contributors, >>>> present and future. >>>> >>> >>> Hi Gary >>> >>> I do not think it would be possible to enforce it through a style >>> check >>> or a commit hook as there are legitimate reasons for one line >>> commits. >>> >>> Please do not get me wrong. I have no intentions of changing your >>> way >>> of working. I fully respect other people's habits. What I am asking >>> is >>> your consent to squash some of your commits (combining small >>> related >>> commit into a larger one). >>> >> >> Oh sure, feel free to do what you want. I did read something a long >> time >> ago warning git users about fiddling with repo history, but since we >> have a >> master repo and we are not truly using git in a distributed way, that >> should not hurt us. >> > > Of course, re-writing history can break forks, but we are not Linux > kernel. I am not aware of a single fork maintained externally. Besides, > rewriting would be limited to the most recent commits. No one is going > to rewrite history more than a few days back. INFRA won't allow that. Master is a propertive branch as far as I know. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org