Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
From: pavolloffay <git@git.apache.org>
To: dev@hc.apache.org
Reply-To: dev@hc.apache.org
References: <git-pr-74-httpclient@git.apache.org>
In-Reply-To: <git-pr-74-httpclient@git.apache.org>
Subject: [GitHub] httpclient pull request #74: WIP: OpenTracing integration
Content-Type: text/plain
Message-Id: <20170512122956.8851FDFE34@git1-us-west.apache.org>
Date: Fri, 12 May 2017 12:29:56 +0000 (UTC)
archived-at: Fri, 12 May 2017 12:29:58 -0000

Github user pavolloffay commented on a diff in the pull request:

    https://github.com/apache/httpclient/pull/74#discussion_r116216114
  
    --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/TracingAsyncExec.java ---
    @@ -0,0 +1,80 @@
    +package org.apache.hc.client5.http.impl.async;
    +
    +import java.io.IOException;
    +import java.net.URISyntaxException;
    +
    +import org.apache.hc.client5.http.async.AsyncExecCallback;
    +import org.apache.hc.client5.http.async.AsyncExecChain;
    +import org.apache.hc.client5.http.async.AsyncExecChain.Scope;
    +import org.apache.hc.client5.http.async.AsyncExecChainHandler;
    +import org.apache.hc.core5.http.EntityDetails;
    +import org.apache.hc.core5.http.HttpException;
    +import org.apache.hc.core5.http.HttpRequest;
    +import org.apache.hc.core5.http.HttpResponse;
    +import org.apache.hc.core5.http.nio.AsyncDataConsumer;
    +import org.apache.hc.core5.http.nio.AsyncEntityProducer;
    +
    +import io.opentracing.Span;
    +import io.opentracing.Tracer;
    +import io.opentracing.Tracer.SpanBuilder;
    +import io.opentracing.contrib.spanmanager.DefaultSpanManager;
    +import io.opentracing.contrib.spanmanager.SpanManager.ManagedSpan;
    +import io.opentracing.tag.Tags;
    +
    +/**
    + * @author Pavol Loffay
    + */
    +public class TracingAsyncExec implements AsyncExecChainHandler {
    +
    +  private Tracer tracer;
    +
    +  public TracingAsyncExec(Tracer tracer) {
    +    this.tracer = tracer;
    +  }
    +
    +  @Override
    +  public void execute(HttpRequest request, AsyncEntityProducer entityProducer, final Scope scope,
    +      AsyncExecChain chain, final AsyncExecCallback asyncExecCallback) throws HttpException, IOException {
    +
    +    SpanBuilder spanBuilder = tracer.buildSpan(request.getMethod())
    +        .withTag(Tags.SPAN_KIND.getKey(), Tags.SPAN_KIND_CLIENT);
    +
    +    ManagedSpan current = DefaultSpanManager.getInstance().current();
    --- End diff --
    
    @ok2c I need your look here.
    
    Does this always run in the same thread as `client.execute()`?
    
    `current` is stored in thread local before calling the client.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org