Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 78E89200C7D for ; Tue, 16 May 2017 09:34:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 77936160BC9; Tue, 16 May 2017 07:34:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B3DB7160B9D for ; Tue, 16 May 2017 09:34:26 +0200 (CEST) Received: (qmail 60903 invoked by uid 500); 16 May 2017 07:34:25 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 60891 invoked by uid 99); 16 May 2017 07:34:25 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 May 2017 07:34:25 +0000 Received: from ok2c (unknown [213.55.211.23]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 1B5501A0331 for ; Tue, 16 May 2017 07:34:24 +0000 (UTC) Message-ID: <1494920061.29580.1.camel@apache.org> Subject: Re: Add getter methods to HttpAsyncService for subclasses to access instance variables From: Oleg Kalnichevski To: HttpComponents Project Date: Tue, 16 May 2017 09:34:21 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit archived-at: Tue, 16 May 2017 07:34:27 -0000 On Mon, 2017-05-15 at 18:29 -0700, Gary Gregory wrote: > In order to my HttpAsyncService to be coded cleanly, I would like to > add > getter methods to HttpAsyncService for subclasses to access instance > variables: > > https://issues.apache.org/jira/browse/HTTPCORE-467 > > Any objections? > > Gary > Is this really needed? One can easily create a private instance variable in the constructor, can't one? This would eliminate the need to expose the internals of the class to its subclasses and to increase the API footprint. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org