hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1725) Heuristic caching does not work for URIs with a query string
Date Tue, 02 May 2017 14:08:04 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Oleg Kalnichevski updated HTTPCLIENT-1725:
           Labels: stuck volunteers-wanted  (was: )
    Fix Version/s: Stuck

> Heuristic caching does not work for URIs with a query string
> ------------------------------------------------------------
>                 Key: HTTPCLIENT-1725
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1725
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCache
>    Affects Versions: 4.5.1
>            Reporter: Charlie Halford
>              Labels: stuck, volunteers-wanted
>             Fix For: Stuck
>         Attachments: HTTPCLIENT-1725_add_query_string_caching.diff
> When enabling heuristic caching and setting a default lifetime, the responses from the
server I am requesting from are not being stored in the cache.
> In org.apache.http.impl.client.cache.ResponseCachingPolicy, line 250 determines if the
URI contains a query string:
> {code}
> request.getRequestLine().getUri().contains("?")
> {code}
> A few lines below, it then checks to see if the response contains cache headers:
> {code}
> else if (!isExplicitlyCacheable(response))
> {code}
> As I am attempting to cache a response that I know does not contain cache headers, the
response should succeed in being cached. However, it fails the isExplictlyCachable() check,
and thus returns false to the overall isResponseCachable() method. The isExplicitlyCachable()
method is checked later on in the stack, so perhaps it can be safely removed here?

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message