hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "yair ogen (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HTTPCLIENT-1826) Async Builder should include setting a ExecutorService
Date Wed, 10 May 2017 10:15:04 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004316#comment-16004316
] 

yair ogen edited comment on HTTPCLIENT-1826 at 5/10/17 10:14 AM:
-----------------------------------------------------------------

oh. so no java 8 default values then :-(

Adding API is exactly aligned with Open Close Principle.

You don't have that many implementations - do you? the PR added implementation where needed.

People do this all the time. You should never freeze an interface in the sense of forbid additions.
you should prevent changing names or removing APIs. That DOES break backward compatibility.




was (Author: yairogen):
oh. that's bad,

Adding API is exactly aligned with Open Close Principle.

You don't have that many implementations - do you? the PR added implementation where needed.

People do this all the time. You should never freeze an interface in the sense of forbid additions.
you should prevent changing names or removing APIs. That DOES break backward compatibility.



> Async Builder should include setting a ExecutorService
> ------------------------------------------------------
>
>                 Key: HTTPCLIENT-1826
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1826
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: yair ogen
>
> Currently you only expose setting ThreadFactory. Not very useful if a user wants to send
in a different thread pool altogether.
> We must have an option to pass in thread pools especially if we want this async work
to co-exist in the same pool as other tasks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message