hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Add getter methods to HttpAsyncService for subclasses to access instance variables
Date Tue, 16 May 2017 08:37:14 GMT
On Tue, 2017-05-16 at 01:32 -0700, Gary Gregory wrote:
> On Tue, May 16, 2017 at 12:34 AM, Oleg Kalnichevski <olegk@apache.org
> >
> wrote:
> 
> > On Mon, 2017-05-15 at 18:29 -0700, Gary Gregory wrote:
> > > In order to my HttpAsyncService to be coded cleanly, I would like
> > > to
> > > add
> > > getter methods to HttpAsyncService for subclasses to access
> > > instance
> > > variables:
> > > 
> > > https://issues.apache.org/jira/browse/HTTPCORE-467
> > > 
> > > Any objections?
> > > 
> > > Gary
> > > 
> > 
> > Is this really needed? One can easily create a private instance
> > variable in the constructor, can't one? This would eliminate the
> > need
> > to expose the internals of the class to its subclasses and to
> > increase
> > the API footprint.
> > 
> 
> Hi Oleg,
> 
> 

...

> My proposed remedy is https://issues.apache.org/jira/browse/HTTPCORE-
> 468
> which refactors HttpAsyncService.handleException such that a subclass
> can
> simply override the new method protected int toStatusCode(final
> Exception
> ex, final HttpContext context)
> 
> Thoughts on that one?
> 

Looks good to me. Feel free to merge it. Try to avoid follow-ups though
if possible ;)

Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message