hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adriancole <...@git.apache.org>
Subject [GitHub] httpclient pull request #74: WIP: OpenTracing integration
Date Sat, 29 Apr 2017 03:13:30 GMT
Github user adriancole commented on a diff in the pull request:

    --- Diff: httpclient5/src/main/java/org/apache/hc/client5/http/impl/sync/HttpClientBuilder.java
    @@ -888,6 +898,10 @@ public void close() throws IOException {
    +        if (tracer != null) {
    +            execChain = new TracingExec(execChain, tracer, DefaultSpanManager.getInstance());
    --- End diff --
    some hook to do the same is the key. I also noticed the redirect problem (which could
be ok as in okhttp we define an application span which makes a child for each network attempt)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message