Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Mon, 20 Mar 2017 13:48:41 +0000 (UTC)
From: "Oleg Kalnichevski (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.13056238.1489572318000.65204.1490017721748@Atlassian.JIRA>
In-Reply-To: <JIRA.13056238.1489572318000@Atlassian.JIRA>
References: <JIRA.13056238.1489572318000@Atlassian.JIRA> <JIRA.13056238.1489572318000@jira-lw-us.apache.org>
Subject: [jira] [Resolved] (HTTPCLIENT-1832) Provide InputStreamBody with
 contentLength if known
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Mon, 20 Mar 2017 13:48:49 -0000


     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1832?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1832.
-------------------------------------------
       Resolution: Fixed
    Fix Version/s: 5.0 Alpha2
                   4.6 Alpha1

Implemented in SVN trunk and 4.6.x branch.=20

Please review and close.

Oleg

> Provide InputStreamBody with contentLength if known
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1832
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-183=
2
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 4.5.3
>         Environment: windows 10 64 bit, oracle jdk 1.8.0_112 64bit
>            Reporter: Marcel Thannh=C3=A4user
>             Fix For: 4.6 Alpha1, 5.0 Alpha2
>
>
> When building a multipart request that consists of at least one body wher=
e the contentLength is -1 in AbstractMultipartForm#getTotalLength -1 is ret=
urned, resulting in a missing Content-Length header in the request. This be=
haviour is correct.=20
> But in some cases you know the contentLength of a body part even though i=
t might be streamed.=20
> To implement this I subclassed org.apache.http.entity.mime.content.InputS=
treamBody=20
> =09public class ContentLengthInputStreamBody extends InputStreamBody {
> =09=09private final long contentLength;
> =09=09
> =09=09public ContentLengthInputStreamBody(InputStream in, ContentType con=
tentType, String filename, long contentLength ) {
> =09=09=09super(in, contentType, filename);
> =09=09=09this.contentLength =3D contentLength;
> =09=09}
> =09=09@Override
> =09=09public long getContentLength() {
> =09=09=09return this.contentLength;
> =09=09}
> =09=09
> =09}
> I also needed to do this because a foreign HTTP Server, which is not unde=
r my control, refused to handle my request when the Content-Length header w=
as not set.
> This might not be a common issue nor is it hard to solve, but you might t=
hink of adding this functionality to InputStreamBody itself.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org