Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 65845200C4B for ; Mon, 20 Mar 2017 11:17:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 644EA160B8F; Mon, 20 Mar 2017 10:17:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B6EE5160B76 for ; Mon, 20 Mar 2017 11:17:45 +0100 (CET) Received: (qmail 82406 invoked by uid 500); 20 Mar 2017 10:17:44 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 82395 invoked by uid 99); 20 Mar 2017 10:17:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Mar 2017 10:17:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 336B81AA980 for ; Mon, 20 Mar 2017 10:17:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 6wY_a8dZ1EyV for ; Mon, 20 Mar 2017 10:17:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1C9F35FE47 for ; Mon, 20 Mar 2017 10:17:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4AB12E08B9 for ; Mon, 20 Mar 2017 10:17:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A5039254D0 for ; Mon, 20 Mar 2017 10:17:41 +0000 (UTC) Date: Mon, 20 Mar 2017 10:17:41 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1830) IdleConnectionEvictor created by HttpClientBuilder should awaitTermination on shutdown MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 20 Mar 2017 10:17:46 -0000 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932438#comment-15932438 ] ASF GitHub Bot commented on HTTPCLIENT-1830: -------------------------------------------- Github user theangrydev commented on the issue: https://github.com/apache/httpclient/pull/69 As discussed in [HTTPCLIENT-1830](https://issues.apache.org/jira/browse/HTTPCLIENT-1830), updated this pull request to keep await termination separate from the shutdown and keeping the change set to a minimum. > IdleConnectionEvictor created by HttpClientBuilder should awaitTermination on shutdown > -------------------------------------------------------------------------------------- > > Key: HTTPCLIENT-1830 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1830 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient (classic) > Affects Versions: 4.5.2 > Reporter: Liam Williams > Fix For: 4.5.4, 5.0 Alpha2 > > > When calling InternalHttpClient.close via the CloseableHttpClient interface for a client created via HttpClientBuilder, IdleConnectionEvictor.shutdown is called, but IdleConnectionEvictor.awaitTermination is not. > This is a problem, since there is no way to await termination apart from doing a dirty sleep. > Hope this makes sense, let me know if it doesn't. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org