Return-Path: <dev-return-35115-archive-asf-public=cust-asf.ponee.io@hc.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 6D32E200C36
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 10 Mar 2017 08:54:14 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 6BDD2160B79; Fri, 10 Mar 2017 07:54:14 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id B272E160B69
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 10 Mar 2017 08:54:13 +0100 (CET)
Received: (qmail 17622 invoked by uid 500); 10 Mar 2017 07:54:12 -0000
Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@hc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@hc.apache.org>
List-Post: <mailto:dev@hc.apache.org>
List-Id: <dev.hc.apache.org>
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Delivered-To: mailing list dev@hc.apache.org
Received: (qmail 17611 invoked by uid 99); 10 Mar 2017 07:54:12 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 07:54:12 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 364D3C6B1B
	for <dev@hc.apache.org>; Fri, 10 Mar 2017 07:54:12 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 1.451
X-Spam-Level: *
X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31
	tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001,
	SPF_NEUTRAL=0.652] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
	with ESMTP id jjy5eWX5b2QN for <dev@hc.apache.org>;
	Fri, 10 Mar 2017 07:54:11 +0000 (UTC)
Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 148D15F23A
	for <dev@hc.apache.org>; Fri, 10 Mar 2017 07:54:11 +0000 (UTC)
Received: from jira-lw-us.apache.org (unknown [207.244.88.139])
	by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D4949E06B9
	for <dev@hc.apache.org>; Fri, 10 Mar 2017 07:54:04 +0000 (UTC)
Received: from jira-lw-us.apache.org (localhost [127.0.0.1])
	by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8E2F1243A8
	for <dev@hc.apache.org>; Fri, 10 Mar 2017 07:54:04 +0000 (UTC)
Date: Fri, 10 Mar 2017 07:54:04 +0000 (UTC)
From: "Gary Gregory (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.13047009.1488298140000.417.1489132444580@Atlassian.JIRA>
In-Reply-To: <JIRA.13047009.1488298140000@Atlassian.JIRA>
References: <JIRA.13047009.1488298140000@Atlassian.JIRA> <JIRA.13047009.1488298140475@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HTTPCLIENT-1828) HttpDelete does not extend
 HttpEntityEnclosingRequestBase
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
archived-at: Fri, 10 Mar 2017 07:54:14 -0000


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904648#comment-15904648 ] 

Gary Gregory commented on HTTPCLIENT-1828:
------------------------------------------

The Javadoc now says:
{code:java}
/**
 * HTTP DELETE method
 * <p>
 * The HTTP DELETE method is defined in section 9.7 of
 * <a href="http://www.ietf.org/rfc/rfc2616.txt">RFC2616</a>:
 * </p>
 * <blockquote> The DELETE method requests that the origin server delete the
 * resource identified by the Request-URI. [...] The client cannot be guaranteed
 * that the operation has been carried out, even if the status code returned
 * from the origin server indicates that the action has been completed
 * successfully. </blockquote>
 * <p>
 * RFC2616 says that a "message-body MUST NOT be included in a request if the
 * specification of the request method (section 5.1.1) does not allow sending an
 * entity-body in requests." Section 5.1.1 then points to
 * https://tools.ietf.org/html/rfc2616#section-9.7 for the DELETE method which
 * in turn does not say anything about allowing or disallowing a message-body.
 * So we allow DELETE to have a body for flexibility.
 * </p>
 * 
 * @since 4.0
 */
{code}

> HttpDelete does not extend HttpEntityEnclosingRequestBase
> ---------------------------------------------------------
>
>                 Key: HTTPCLIENT-1828
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1828
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.5.1, 4.5.2, 4.5.3
>            Reporter: Saravanakumar Selvaraj
>             Fix For: 4.5.4, 5.0 Alpha1
>
>
> Sending body in DELETE is allowed as the HTTP 1.1 specification does not forbid. Hence HttpDelete.class should extend from HttpEntityEnclosingRequestBase instead of HttpRequestBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org