Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Mon, 20 Mar 2017 10:45:41 +0000 (UTC)
From: "Oleg Kalnichevski (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.12757631.1416901018000.64274.1490006741888@Atlassian.JIRA>
In-Reply-To: <JIRA.12757631.1416901018000@Atlassian.JIRA>
References: <JIRA.12757631.1416901018000@Atlassian.JIRA> <JIRA.12757631.1416901018582@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HTTPCLIENT-1583) Add option to create a
 connection eviction thread for a non-shared connection manager
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 20 Mar 2017 10:45:51 -0000


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932478#comment-15932478 ] 

Oleg Kalnichevski commented on HTTPCLIENT-1583:
-----------------------------------------------

Ah, yes, you are right. I did a mistake. The IdleConnectionEvictor constructor call should have been something like that

{code:java}
final IdleConnectionEvictor connectionEvictor = new IdleConnectionEvictor((ConnPoolControl<?>) connManagerCopy,
    maxIdleTime > 0 ? maxIdleTime : 10, maxIdleTimeUnit != null ? maxIdleTimeUnit : TimeUnit.SECONDS,
    maxIdleTime, maxIdleTimeUnit);
{code}

Feel free to raise a JIRA or / and a PR at Github for this defect.

Oleg

> Add option to create a connection eviction thread for a non-shared connection manager
> -------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1583
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1583
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.3.5
>            Reporter: yair ogen
>            Priority: Minor
>             Fix For: 4.4 Final
>
>
> In the tutorial:
> http://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html, section 2.5 Connection eviction policy - you explain how to clean-up connections. Although I can argue against the design as without this if server closes connections, my client gets many sockets stuck on CLOSE_WAIT - adding this thread solves the CLOSE_WAIT issue. 
> However, I don't understand why you don't do this yourself if keep-alive is set. I would expect the library to support such a thread. In the meanwhile, it seems that if I use the default connection manager, I can't use non-deprecated code to call :
> connMgr.closeExpiredConnections();
> and
> connMgr.closeIdleConnections(30, TimeUnit.SECONDS);
> This is because the only exposed API to get the default pooling connection manager is by calling:
> httpClient.getConnectionManager(), which is deprecated. Javadoc suggests to go to the builder (which I do use but not for creating connection pool as the default is good enough for me) which is useless.
> So - how should one acquire a reference to the connection manager?


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org