hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1830) IdleConnectionEvictor created by HttpClientBuilder should awaitTermination on shutdown
Date Mon, 20 Mar 2017 10:17:41 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932437#comment-15932437
] 

ASF GitHub Bot commented on HTTPCLIENT-1830:
--------------------------------------------

Github user theangrydev commented on the issue:

    https://github.com/apache/httpclient/pull/68
  
    As discussed in [HTTPCLIENT-1830](https://issues.apache.org/jira/browse/HTTPCLIENT-1830),
updated this pull request to keep await termination separate from the shutdown and keeping
the change set to a minimum.


> IdleConnectionEvictor created by HttpClientBuilder should awaitTermination on shutdown
> --------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1830
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1830
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient (classic)
>    Affects Versions: 4.5.2
>            Reporter: Liam Williams
>             Fix For: 4.5.4, 5.0 Alpha2
>
>
> When calling InternalHttpClient.close via the CloseableHttpClient interface for a client
created via HttpClientBuilder, IdleConnectionEvictor.shutdown is called, but IdleConnectionEvictor.awaitTermination
is not.
> This is a problem, since there is no way to await termination apart from doing a dirty
sleep.
> Hope this makes sense, let me know if it doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message