hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1828) HttpDelete does not extend HttpEntityEnclosingRequestBase
Date Fri, 10 Mar 2017 08:43:09 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904727#comment-15904727
] 

Julian Reschke commented on HTTPCLIENT-1828:
--------------------------------------------

bq. You are very welcome to have a different opinion but a simple, irrefutable fact is that
HttpClient 4.x has been built to conform to RFC 2616. It makes no sense to make it partially
compliant with RFC723x in some areas and non-complaint in some others.

Well, it should be built to conform to HTTP/1.1. Being partially compliant to the newer spec
certainly isn't ideal, but nor is it to be compliant to an obsolete spec.

bq. And what makes absolutely no sense of what so ever is DELETE and GET with enclosed entity.

I agree that it shouldn't be used. The question is whether the HTTP client library should
enforce this.

> HttpDelete does not extend HttpEntityEnclosingRequestBase
> ---------------------------------------------------------
>
>                 Key: HTTPCLIENT-1828
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1828
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.5.1, 4.5.2, 4.5.3
>            Reporter: Saravanakumar Selvaraj
>             Fix For: 4.5.4, 5.0 Alpha1
>
>
> Sending body in DELETE is allowed as the HTTP 1.1 specification does not forbid. Hence
HttpDelete.class should extend from HttpEntityEnclosingRequestBase instead of HttpRequestBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message