hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1828) HttpDelete does not extend HttpEntityEnclosingRequestBase
Date Mon, 13 Mar 2017 15:19:41 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907643#comment-15907643
] 

Oleg Kalnichevski commented on HTTPCLIENT-1828:
-----------------------------------------------

Hi Gary
Clirr check will likely pass as {{HttpDelete}} has been made to implement an optional interface.
The problem is that if released in a patch release (like 4.5.4) API visible changes automatically
become a part of the public APIs without any chance of being revised or corrected in case
of compatibility problems or user feedback. We have already done a number of such changes
in the 4.5 release series, but changing {HttpGet}} to extend {{HttpEntityEnclosingRequestBase}}
would be too big to just sneak in and hope that no one notices.

No need to rush it, though. Not until you are back home.

Oleg

> HttpDelete does not extend HttpEntityEnclosingRequestBase
> ---------------------------------------------------------
>
>                 Key: HTTPCLIENT-1828
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1828
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.5.1, 4.5.2, 4.5.3
>            Reporter: Saravanakumar Selvaraj
>             Fix For: 4.5.4, 5.0 Alpha1
>
>
> Sending body in DELETE is allowed as the HTTP 1.1 specification does not forbid. Hence
HttpDelete.class should extend from HttpEntityEnclosingRequestBase instead of HttpRequestBase.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message