hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ok2c <...@git.apache.org>
Subject [GitHub] httpcore pull request #40: add a provider parameter in SSLContextBuilder
Date Fri, 31 Mar 2017 12:06:48 GMT
Github user ok2c commented on a diff in the pull request:

    --- Diff: httpcore/src/main/java/org/apache/http/ssl/SSLContextBuilder.java ---
    @@ -272,6 +274,20 @@ public SSLContext build() throws NoSuchAlgorithmException, KeyManagementExceptio
             return sslcontext;
    +    public SSLContext buildWithProvider(final Provider provider) throws NoSuchAlgorithmException,
KeyManagementException {
    --- End diff --
    Fair point. However I am not sure this change should go into 4.4. In 5.0 we can change
APIs as we deem fit.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message