hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaddyWri <...@git.apache.org>
Subject [GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked
Date Thu, 16 Mar 2017 11:57:01 GMT
Github user DaddyWri commented on the issue:

    https://github.com/apache/httpclient/pull/66
  
    The branch, by the way, now has everything in it except the NTLMScheme changes, which
essentially did nothing more than deprecate the standard NTLMScheme, which was not a reasonable
way of doing things.
    
    - I haven't written any new tests yet; patches welcome if anyone wants to tackle this
    - It looks like Mr. Semancik wanted to fundamentally change the NTLMEngine API, which
of course is
      not going to be something that can be done for backwards compatibility reasons
    - The NTLMEngine itself is now stateful, as discussed before; this approach doesn't impress
me as being
      a good idea, so I've made the methods that care about the previous NTLMMessages in the
state be
      explicit arguments to the Type3Message constructor (at least one such variant)
    - My thought is that the CredSspScheme should do the job of keeping track of previous
messages, since
      it has to keep much state anyway, and then we can rip out the new statefulness of the
NTLMEngine
      since it doesn't really belong there
    - Much of the packing of new packets, though, should be moved into NTLMEngineImpl



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message