hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From semancik <...@git.apache.org>
Subject [GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked
Date Wed, 15 Mar 2017 10:47:44 GMT
Github user semancik commented on the issue:

    https://github.com/apache/httpclient/pull/66
  
    I'm OK with adapting to a coding conventions. I have done that for several projects. But
I would like to know the conventions from the beginning. I have adapted my contributions to
the checkstyle that you have set up - even if that was costing a lot of my time. I have adapted
to conventions that I believed are applicable to your project (even if I have that formatting
style personally). I have already done all of that. But, it turns out, I have used wrong conventions.
And why is that? Because I could not find anything about your coding conventions on your website.
I could not even find link to the source code on your website. Therefore look at that from
my point of view: I have done all that I could do adapt to your project. And all I get for
that is criticism. That isn't really a reason to be happy about my contribution. That is not
a good motivation to put any extra work in that, is it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message