hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaddyWri <...@git.apache.org>
Subject [GitHub] httpclient issue #66: CredSSP implementation, NTLM engine reworked
Date Tue, 14 Mar 2017 17:28:45 GMT
Github user DaddyWri commented on the issue:

    https://github.com/apache/httpclient/pull/66
  
    Hi @semancik, the Apache standard can be overridden on a group-by-group basis, but the
global standards are as follows:
    
    - 4 spaces for each indent, no tabs
    - braces in this style:
    if {
    } else {
    }
    - single space after commas in functions
    - no spaces after or before parens, e.g. "( 1, 2 )"
    
    This project's checkstyle is pretty rigorous but does not enforce all of the Apache standards.
    It is indeed a challenge to work with, but is pretty self-explanatory when it finds a
problem.
    
    More importantly, it's just simply impossible to read diffs that include global reformatting.
 I therefore discourage people from reformatting as a matter of course because it does make
unnecessarily hard to evaluate submissions.  I'm not sure why you felt it necessary to *change*
the style that was in place, but I have plodded through the diff, as it is, and if others
agree it's acceptable in the current form, I will defer to that.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message