Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Tue, 7 Feb 2017 06:11:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.13039088.1485835345000.13132.1486447902412@Atlassian.JIRA>
In-Reply-To: <JIRA.13039088.1485835345000@Atlassian.JIRA>
References: <JIRA.13039088.1485835345000@Atlassian.JIRA> <JIRA.13039088.1485835345902@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HTTPCLIENT-1810) URIBuilder.toString() always
 adds '/' to path, even with query parameters
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Feb 2017 06:11:52 -0000


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855401#comment-15855401 ] 

ASF GitHub Bot commented on HTTPCLIENT-1810:
--------------------------------------------

GitHub user Coderec opened a pull request:

    https://github.com/apache/httpcore/pull/37

    [HTTPCLIENT-1810] URIBuilder.toString() always adds '/' to path, even with query parameters 

    When the path is null or '', URIBuilder.normalizePath() should return '' rather than '/'.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Coderec/httpcore cuibaosen/HTTPCLIENT-1810

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcore/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit 2fa5e61bd7ceed7fc3b79db100db6586c6da7bf5
Author: CuiBaosen <baosencumt@126.com>
Date:   2017-02-07T06:08:36Z

    When the path is null or '', URIBuilder.normalizePath() should return '' rather than '/'.

----


> URIBuilder.toString() always adds '/' to path, even with query parameters
> -------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1810
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1810
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5.3
>            Reporter: Osvaldo Pinali Doederlein
>
> I get results like this:
> http://a.io:999/?p1=v1&p2=v2
> previously, it was correct
> http://a.io:999?p1=v1&p2=v2


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org