Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
From: Coderec <git@git.apache.org>
To: dev@hc.apache.org
Reply-To: dev@hc.apache.org
References: <git-pr-64-httpclient@git.apache.org>
In-Reply-To: <git-pr-64-httpclient@git.apache.org>
Subject: [GitHub] httpclient pull request #64: [HTTPCLIENT-1810] URIBuilder.toString() always ...
Content-Type: text/plain
Message-Id: <20170208003533.C4A3BDFBDB@git1-us-west.apache.org>
Date: Wed,  8 Feb 2017 00:35:33 +0000 (UTC)
archived-at: Wed, 08 Feb 2017 00:35:35 -0000

Github user Coderec commented on a diff in the pull request:

    https://github.com/apache/httpclient/pull/64#discussion_r99967058
  
    --- Diff: httpclient/src/main/java/org/apache/http/client/utils/URIBuilder.java ---
    @@ -492,8 +492,8 @@ public String toString() {
     
         private static String normalizePath(final String path) {
             String s = path;
    -        if (s == null) {
    -            return "/";
    +        if (s == null || "".equals(s)) {
    +            return "";
    --- End diff --
    
    Hi garygregory,
    s == null || "".equals(s) has been changed to TextUtils.isBlank(s), which would be better. isn't it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org