hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1810) URIBuilder.toString() always adds '/' to path, even with query parameters
Date Wed, 08 Feb 2017 01:37:42 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857199#comment-15857199
] 

ASF GitHub Bot commented on HTTPCLIENT-1810:
--------------------------------------------

Github user garydgregory commented on the issue:

    https://github.com/apache/httpclient/pull/64
  
    Yes!
    
    On Tue, Feb 7, 2017 at 4:35 PM, Coderec <notifications@github.com> wrote:
    
    > *@Coderec* commented on this pull request.
    > ------------------------------
    >
    > In httpclient/src/main/java/org/apache/http/client/utils/URIBuilder.java
    > <https://github.com/apache/httpclient/pull/64>:
    >
    > > @@ -492,8 +492,8 @@ public String toString() {
    >
    >      private static String normalizePath(final String path) {
    >          String s = path;
    > -        if (s == null) {
    > -            return "/";
    > +        if (s == null || "".equals(s)) {
    > +            return "";
    >
    > Hi garygregory,
    > s == null || "".equals(s) has been changed to TextUtils.isBlank(s), which
    > would be better. isn't it?
    >
    > —
    > You are receiving this because you commented.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/httpclient/pull/64>, or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/ABIfNzFun4X4X5pmRQpIbE9Sti7Spt-oks5raQ3TgaJpZM4L5AXW>
    > .
    >
    
    
    
    -- 
    E-Mail: garydgregory@gmail.com | ggregory@apache.org
    Java Persistence with Hibernate, Second Edition
    <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
    
    <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
    JUnit in Action, Second Edition
    <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
    
    <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
    Spring Batch in Action
    <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
    <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
    Blog: http://garygregory.wordpress.com
    Home: http://garygregory.com/
    Tweet! http://twitter.com/GaryGregory



> URIBuilder.toString() always adds '/' to path, even with query parameters
> -------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1810
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1810
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5.3
>            Reporter: Osvaldo Pinali Doederlein
>
> I get results like this:
> http://a.io:999/?p1=v1&p2=v2
> previously, it was correct
> http://a.io:999?p1=v1&p2=v2



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message