hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmouawad <...@git.apache.org>
Subject [GitHub] httpclient issue #65: Make some package protected classes public as we need ...
Date Wed, 22 Feb 2017 11:21:05 GMT
Github user pmouawad commented on the issue:

    https://github.com/apache/httpclient/pull/65
  
    @ok2c , @fxbonnet , I am aware of the fact that classes are deprecated, see how we use
them and the javadocs:
    
    - https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
    
    Doing what you propose means for me  copy/pasting the 3 classes in JMeter, which I don't
find it better.
    Migrating fully to 4.5 new code is identified:
    
    - https://bz.apache.org/bugzilla/show_bug.cgi?id=58757
    
    Still, the migration is not a little piece of cake and for us does not bring enough ROI
to be done.
    JMeter relied on "advanced" api of HC4 and although I know you make a lot of effort, documentation
for migration was not complete at all for such parts.
    
    @ok2c helped a lot on Cookie migration which was important feature for us. We're using
new APIs for new code , like Async Backend Listener that interracts with InfluxDB, but as
you know we have to make some choice as time is not infinite :-) 
    
    In the future and if possible, it would be nice when you deprecate an API to mention in
javadoc its new class equivalent. It's not done everywhere.
    
    As Http2 is expected in 5.0, for now I must say I prefer to do migration at that time.
    
    But @ok2c  if you don't want to merge the PR, I'll do that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message