hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From garydgregory <...@git.apache.org>
Subject [GitHub] httpclient issue #64: [HTTPCLIENT-1810] URIBuilder.toString() always adds '/...
Date Wed, 08 Feb 2017 01:37:17 GMT
Github user garydgregory commented on the issue:

    https://github.com/apache/httpclient/pull/64
  
    Yes!
    
    On Tue, Feb 7, 2017 at 4:35 PM, Coderec <notifications@github.com> wrote:
    
    > *@Coderec* commented on this pull request.
    > ------------------------------
    >
    > In httpclient/src/main/java/org/apache/http/client/utils/URIBuilder.java
    > <https://github.com/apache/httpclient/pull/64>:
    >
    > > @@ -492,8 +492,8 @@ public String toString() {
    >
    >      private static String normalizePath(final String path) {
    >          String s = path;
    > -        if (s == null) {
    > -            return "/";
    > +        if (s == null || "".equals(s)) {
    > +            return "";
    >
    > Hi garygregory,
    > s == null || "".equals(s) has been changed to TextUtils.isBlank(s), which
    > would be better. isn't it?
    >
    > —
    > You are receiving this because you commented.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/httpclient/pull/64>, or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/ABIfNzFun4X4X5pmRQpIbE9Sti7Spt-oks5raQ3TgaJpZM4L5AXW>
    > .
    >
    
    
    
    -- 
    E-Mail: garydgregory@gmail.com | ggregory@apache.org
    Java Persistence with Hibernate, Second Edition
    <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
    
    <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
    JUnit in Action, Second Edition
    <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
    
    <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
    Spring Batch in Action
    <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
    <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
    Blog: http://garygregory.wordpress.com
    Home: http://garygregory.com/
    Tweet! http://twitter.com/GaryGregory



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message