hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1808) Overflow in Connection TTL
Date Sat, 28 Jan 2017 00:11:25 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843685#comment-15843685
] 

ASF GitHub Bot commented on HTTPCLIENT-1808:
--------------------------------------------

GitHub user shorea opened a pull request:

    https://github.com/apache/httpcore/pull/35

    [HTTPCLIENT-1808] Fixing potential overflow for connection TTL

    My IDE got a little overzealous with the imports. Let me know if you want me to revert.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shorea/httpcore 4.4.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpcore/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit f41999aed4f17e083cca89151e00dfb5318360a8
Author: Andrew Shore <shorea@amazon.com>
Date:   2017-01-28T00:09:15Z

    [HTTPCLIENT-1808] Fixing potential overflow for connection TTL

----


> Overflow in Connection TTL
> --------------------------
>
>                 Key: HTTPCLIENT-1808
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1808
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (classic)
>    Affects Versions: 4.5.3
>            Reporter: Andrew Shore
>            Priority: Minor
>              Labels: easyfix, performance
>             Fix For: 4.5.4, 5.0 Alpha3
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> There is a possibility of an overflow at https://github.com/apache/httpcore/blob/4.4.x/httpcore/src/main/java/org/apache/http/pool/PoolEntry.java#L88
when calculating the validity deadline. When Long.MAX_VALUE (or values sufficiently close
to it) is used as the TTL it results in a negative validity deadline which causes every connection
to be single use. This is very surprising behavior and may not be immediately obvious in test
environments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message