hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCLIENT-1803) Malformed path not handled well
Date Sat, 21 Jan 2017 14:46:26 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCLIENT-1803.
-------------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 5.0 Alpha2)

{{URIBuilder}} has been moved from client to core
https://github.com/apache/httpcore/blob/trunk/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java

Fixed committed to HttpCore trunk and HttpClient 4.5.x branch. Please review and close.

Oleg

> Malformed path not handled well
> -------------------------------
>
>                 Key: HTTPCLIENT-1803
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1803
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async), HttpClient (classic)
>    Affects Versions: 4.5.1
>            Reporter: Tyler Benson
>             Fix For: 4.5.3
>
>
> When using URIBuilder's constructor with a malformed url argument, host passed in by
{{setHost}} call not honored.
> {quote}
>         String path = "@notexample.com/mypath"
>         URI uri = new URIBuilder(path).setHost("example.com").build();
>         org.junit.Assert.assertEquals("example.com", uri.getHost())
> {quote}
> This is caused by the original string being passed into the constructor being treated
as the path, but not verifying the presence of a leading {{/}} character.
> This can be seen with other arguments:
> {{path = "example"}} -> {{//example.comexample}}
> Fix:  URIBuilder should ensure path starts with a leading {{/}}.
> Reason priority is considered Major:
> In our case, this caused a security vulnerability which was discovered by researcher
James Kettle (@albinowax on twitter). The user-provided path was able to override our specified
host, resulting in giving network access to a sensitive environment.  We worked around this
in our code by ensuring the leading {{/}}, but this seems like something better handled by
the framework.
> PS.  If you agree this should be fixed, I'm happy to submit a pull request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message