hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-439) Contribute BasicHeader override of equals and hashcode
Date Thu, 22 Dec 2016 16:42:58 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770471#comment-15770471
] 

ASF GitHub Bot commented on HTTPCORE-439:
-----------------------------------------

Github user lewijw commented on the issue:

    https://github.com/apache/httpcore/pull/32
  
    Thanks for making the changes and expediting this to get it in the alpha2 release.  I
got rid of some redundant test code.  I am also assuming these headers are equal (the sensitivity
is of no concern with equality):
            final Header header = new BasicHeader("name", "value", true);
            final Header header2 = new BasicHeader("name", "value", false);
    
    When is the alpha2 release?



> Contribute BasicHeader override of equals and hashcode
> ------------------------------------------------------
>
>                 Key: HTTPCORE-439
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-439
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: Contrib, HttpCore
>    Affects Versions: 5.0-alpha2
>         Environment: All
>            Reporter: John Lewis
>             Fix For: 5.0-alpha2
>
>
> When removing headers from a HeaderGroup, the header is only removed if the header you
are trying to remove is an object in the header list.  It seems it would be better if headers
were removed that matched the name and value of one of the objects in the list.  To accomplish
this, I have overridden the equals and hashCode methods in BasicHeader.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message