hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCORE-390) Lock-less connection pools
Date Sun, 04 Dec 2016 14:38:58 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15720045#comment-15720045
] 

Oleg Kalnichevski commented on HTTPCORE-390:
--------------------------------------------

In case anyone is watching this issue: the connection pooling logic and APIs got revised and
decoupled from any particular i/o model. The same connection pool now is used by both blocking
and non-blocking transports. This should also makes it significantly easier to implement a
lock-less (or concurrent or lax) connection pool instead of the strict pool implementation
presently used in HC 5.0 [1]

Oleg

[1] https://github.com/apache/httpcore/blob/trunk/httpcore5/src/main/java/org/apache/hc/core5/pool/StrictConnPool.java

> Lock-less connection pools
> --------------------------
>
>                 Key: HTTPCORE-390
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-390
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.3.2
>            Reporter: Stephane Routhiau
>              Labels: concurrency, performance
>             Fix For: 5.0
>
>         Attachments: AbstractNIOConnPool.java, ConcurrentLinkedQueue.java, DefaultConnectingIOReactor.java,
RouteSpecificPool.java, SessionRequestCallback.java, contention on lease and release.png,
patch-performance nio pool.patch
>
>
> AbstractNIOConnPool use a ReentrantLock for lease and release connection.
> We have noticed important contention when we try to use hundreds of connexions to the
same host, the lock is to vast.
> I managed to rework a part of the code so there is no more use of a ReentrantLock, but
use of ConcurrentHashMap and so on.
> The unit tests are ok and the load tests we have made on the patch version are about
40 % faster under heavy load
> Please find attached patch file againt http-nio 4.3.2 and the modified sources files
of http-nio 4.3.2



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message