hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Detlev Beutner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1006) BrowserCompatSpec: don't trim " around cookie value
Date Thu, 29 Dec 2016 18:15:58 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785802#comment-15785802
] 

Detlev Beutner commented on HTTPCLIENT-1006:
--------------------------------------------

Oleg, please, let's stop this "no it does not" game without any reasoning. Let's assume you
are right and I'm wrong: How should I learn from "no it does not"?! Doesn't help anybody.

Anyhow, I gave the reason several times now and referred to it here again. Formal it is in
4.2.1, less formal it is in "The cookie-pair contains the cookie-name and _cookie-value the
user agent received in the Set-Cookie header_." (4.2.2)

I really don't understand the whole hassle. It's as plain and simple as the sentence from
above (4.2.2) can be.

Please keep in mind that primarily, this is not a theoretical discussion (but the theory underscores
the reality, at least). It is about an implementation which _does break things up_. That's
why I have opened my comments with a concrete example (of a really big site used thousands
of times per day).

> BrowserCompatSpec: don't trim " around cookie value
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1006
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1006
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (classic)
>    Affects Versions: 4.0.2
>            Reporter: Marc Guillemot
>
> If the server sends a cookie header like:
> Set-Cookie: first="hello world"
> then HttpClient parses it as cookie with value >hello world<, wrongly removing
the leading and trailing quotes. The incorrect quote removal occurs in BasicHeaderValueParser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message