Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Date: Mon, 19 Sep 2016 14:17:20 +0000 (UTC)
From: "Sergiu Prodan (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Message-ID: <JIRA.13005920.1474294620000.605695.1474294640855@Atlassian.JIRA>
In-Reply-To: <JIRA.13005920.1474294620000@Atlassian.JIRA>
References: <JIRA.13005920.1474294620000@Atlassian.JIRA> <JIRA.13005920.1474294620474@arcas>
Subject: [jira] [Created] (HTTPCORE-433) Setting validateAfterInactivity to
 1ms increases lock contention in AbstractConnPool
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 19 Sep 2016 14:17:23 -0000

Sergiu Prodan created HTTPCORE-433:
--------------------------------------

             Summary: Setting validateAfterInactivity to 1ms increases lock contention in AbstractConnPool
                 Key: HTTPCORE-433
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-433
             Project: HttpComponents HttpCore
          Issue Type: Bug
          Components: HttpCore
    Affects Versions: 4.4.4
            Reporter: Sergiu Prodan


This issue was observed after upgrading to httpclient v4.5.2 and httpcore v4.4.4. 

When configuring the PoolingHttpClientConnectionManager, I have set validateAfterInactivity to 1ms as this is the only way of maintaining the old behaviour, i.e. checking every connection if is stale before using it.

I have observed a performance degradation under high load when the httpclient is shared between multiple threads. 

After taking a thread dump, one thing that got my attention was several threads waiting for same ReentrantLock instance while trying to AbstractConnPool#getPoolEntryBlocking
/AbstractConnPool#release. The ReentrantLock instance in question was owned by another thread performing CPool#validate.

It seems to me that performing this stale check inside the region protected by this lock is unnecessary and also induces a big performance hit when using the httpclient from multiple threads.

I've atached a thread dump of a test application that reproduces this behaviour. ReentrantLock in question in this thread dump is 0x0000000706e8b9a8 and is owned by Thread-4


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org