hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hirthwork <...@git.apache.org>
Subject [GitHub] httpcore issue #30: HTTPCORE-431 Fix EntityUtils encoding for application/js...
Date Sun, 04 Sep 2016 11:11:21 GMT
Github user hirthwork commented on the issue:

    https://github.com/apache/httpcore/pull/30
  
    
    
    > To be clear, the performance penalty you're thinking of is a string comparison of
the MIME type?
    I'm talking about single bytes reading and input streams concatenation.
    
    Also, what will happen for empty responses? This code will return non-empty string, which
is incorrect. Same for some single byte responses.
    
    I completely agree with you, that ContentType.parse("application/json") should return
ContentType.APPLICATION_JSON.
    But it is appropriate to introduce this changes only in ContentType class, leaving other
classes untouched.
    This will perfectly match statement concerning [default encoding](https://tools.ietf.org/html/rfc7159#section-8.1)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message