hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetripodi <...@git.apache.org>
Subject [GitHub] httpclient pull request #56: HTTPCLIENT-1752 - Allow to configure the OSGI c...
Date Mon, 25 Jul 2016 13:13:27 GMT
Github user simonetripodi commented on a diff in the pull request:

    https://github.com/apache/httpclient/pull/56#discussion_r72060532
  
    --- Diff: httpclient5-osgi/src/main/java/org/apache/hc/client5/http/osgi/impl/RelaxedLayeredConnectionSocketFactory.java
---
    @@ -0,0 +1,101 @@
    +/*
    + * ====================================================================
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + * ====================================================================
    + *
    + * This software consists of voluntary contributions made by many
    + * individuals on behalf of the Apache Software Foundation.  For more
    + * information on the Apache Software Foundation, please see
    + * <http://www.apache.org/>.
    + *
    + */
    +package org.apache.hc.client5.http.osgi.impl;
    +
    +import static org.apache.hc.client5.http.osgi.impl.HostMatcher.HostMatcherFactory.createMatcher;
    +import static org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory.getSocketFactory;
    +
    +import java.io.IOException;
    +import java.net.InetSocketAddress;
    +import java.net.Socket;
    +
    +import org.apache.hc.client5.http.osgi.services.TrustedHostsConfiguration;
    +import org.apache.hc.client5.http.socket.LayeredConnectionSocketFactory;
    +import org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory;
    +import org.apache.hc.core5.http.HttpHost;
    +import org.apache.hc.core5.http.protocol.HttpContext;
    +import org.osgi.framework.BundleContext;
    +import org.osgi.framework.ServiceRegistration;
    +
    +final class RelaxedLayeredConnectionSocketFactory implements LayeredConnectionSocketFactory
{
    +
    +    private final SSLConnectionSocketFactory defaultSocketFactory = getSocketFactory();
    --- End diff --
    
    @ok2c I just implemented the required behaviour in my last commit, tests are up and running
- any feedback would be more than appreciated, thanks in advance!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message