hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Justin Edelson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1749) Memory Leak in OSGi support
Date Fri, 10 Jun 2016 17:25:20 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324876#comment-15324876
] 

Justin Edelson commented on HTTPCLIENT-1749:
--------------------------------------------

[~olegk] totally understand. I don't think it is worthwhile to deprecate the class and replace
it, but I did make the new class added in HTTPCLIENT-1750 to avoid this issue in the future.

> Memory Leak in OSGi support
> ---------------------------
>
>                 Key: HTTPCLIENT-1749
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1749
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.4.1, 4.5.2
>            Reporter: Justin Edelson
>         Attachments: HTTPCLIENT-1749-2.diff, HTTPCLIENT-1749.patch
>
>
> There is a memory leak in the HTTP Client OSGi support whereby the HttpProxyConfigurationActivator
holds on to references to created HttpClient instances for the entire life of the httpclient-osgi
bundle, which may be (and probably is in many cases) longer than the lifespan of individual
HttpClient instances.
> The clients are added here: http://grepcode.com/file/repo1.maven.org/maven2/org.apache.httpcomponents/httpclient-osgi/4.4.1/org/apache/http/osgi/impl/OSGiHttpClientBuilder.java#58
> and not removed until http://grepcode.com/file/repo1.maven.org/maven2/org.apache.httpcomponents/httpclient-osgi/4.4.1/org/apache/http/osgi/impl/HttpProxyConfigurationActivator.java#115
> This can be relatively easily fixed by using weak references. In addition, access to
this collection needs to be synchronized because the additions may come from multiple threads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message