hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCORE-422) BasicAsyncResponseConsumer#onEntityEnclosed is triggered for HEAD responses
Date Sat, 18 Jun 2016 12:19:05 GMT

     [ https://issues.apache.org/jira/browse/HTTPCORE-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCORE-422.
----------------------------------------
       Resolution: Fixed
    Fix Version/s: 5.0-alpha2

Committed to SVN trunk and 4.4.x branch.

Oleg

> BasicAsyncResponseConsumer#onEntityEnclosed is triggered for HEAD responses
> ---------------------------------------------------------------------------
>
>                 Key: HTTPCORE-422
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-422
>             Project: HttpComponents HttpCore
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 4.4.5
>            Reporter: Tom Fitzhenry
>            Assignee: Oleg Kalnichevski
>            Priority: Minor
>             Fix For: 4.4.6, 5.0-alpha2
>
>
> HttpAsyncRequestExecutor#responseReceived(NHttpClientConnection) calls HttpAsyncResponseConsumer#responseReceived(HttpResponse)
via HttpAsyncClientExchangeHandler#responseReceived(HttpResponse).
> See https://github.com/apache/httpcore/blob/4.4.x/httpcore-nio/src/main/java/org/apache/http/nio/protocol/HttpAsyncRequestExecutor.java#L302
.
> It does this even if the request is a HEAD request. If your HttpAsyncResponseConsumer
is a BasicAsyncResponseConsumer, then this will allocate a buffer of size content-length kB
(or 4kB, if content-length does not exist).
> For a simple proxying Java app, profiling revealed this the allocation due to this was
a bottleneck.
> It'd be nice if 
> Are there use cases for calling HttpAsyncResponseConsumer#responseReceived(HttpResponse)
on HEAD requests? If not, perhaps it could not be called.
> FWIW, it looks like httpclient doe not call the corresponding method for HEAD requests:
https://github.com/apache/httpcore/blob/4.4.x/httpcore/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java#L273-L275



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message