hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Briskin (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1746) URLEncodedUtils.parse(String, CharSet) in 4.4 causes an NPE on null input and is not backward compatible
Date Fri, 27 May 2016 20:38:12 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steve Briskin updated HTTPCLIENT-1746:
--------------------------------------
    Description: 
In 4.2 and 4.3, {{URLEncodedUtils.parse(String, CharSet)}} returns an empty List for a null
String input.  

In 4.4, {{URLEncodedUtils.parse(null, Charset.forName("UTF-8"))}} throws an NullPointerException.

For the sake of API backward compatibility, parse(String, CharSet) should return an empty
list.

Note that parse(String, CharSet, char...) does the null check and returns an empty list. 
I think parse(String, CharSet) should have the same behavior.

  was:
In 4.2 and 4.3, {{URLEncoderUtils.parse(String, CharSet)}} returns an empty List for a null
String input.  

In 4.4, {{URLEncoderUtils.parse(null, Charset.forName("UTF-8"))}} throws an NullPointerException.

For the sake of API backward compatibility, parse(String, CharSet) should return an empty
list.

Note that parse(String, CharSet, char...) does the null check and returns an empty list. 
I think parse(String, CharSet) should have the same behavior.


> URLEncodedUtils.parse(String, CharSet) in 4.4 causes an NPE on null input and is not
backward compatible
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1746
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1746
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>            Reporter: Steve Briskin
>
> In 4.2 and 4.3, {{URLEncodedUtils.parse(String, CharSet)}} returns an empty List for
a null String input.  
> In 4.4, {{URLEncodedUtils.parse(null, Charset.forName("UTF-8"))}} throws an NullPointerException.
> For the sake of API backward compatibility, parse(String, CharSet) should return an empty
list.
> Note that parse(String, CharSet, char...) does the null check and returns an empty list.
 I think parse(String, CharSet) should have the same behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message