hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Kelley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1744) code treats domain names or hostnames case sensitive. This will cause verification to fail because FQDN are case insensitive.
Date Thu, 19 May 2016 20:19:12 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292062#comment-15292062
] 

James Kelley commented on HTTPCLIENT-1744:
------------------------------------------

Well if I understand what you are say, you wish the bug to be moved further up in the stack
because it should be normalized prior. Which is fine, where do you think it should be normalized?

org.apache.hc.client5.http.methods.HttpGet() is where it comes in. 

So some where between HttpGet method and matchDomainRoot method? 

> code treats domain names or hostnames case sensitive. This will cause verification to
fail because FQDN are case insensitive.
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1744
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1744
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient, HttpConn
>    Affects Versions: 4.5.1, 4.5.2, 5.0 Alpha1
>            Reporter: James Kelley
>
> in class DefaultHostnameVerifier in the method  static boolean matchDomainRoot(final
String host, final String domainRoot); and maybe else where the code treats domain names or
hostnames case sensitive. This will cause verification to fail because FQDN are case insensitive.
> host.endsWith(domainRoot)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message