Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4CFBD18710 for ; Mon, 7 Mar 2016 19:43:42 +0000 (UTC) Received: (qmail 67441 invoked by uid 500); 7 Mar 2016 19:43:41 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 67044 invoked by uid 500); 7 Mar 2016 19:43:41 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 66304 invoked by uid 99); 7 Mar 2016 19:43:41 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Mar 2016 19:43:41 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D218D2C1F69 for ; Mon, 7 Mar 2016 19:43:40 +0000 (UTC) Date: Mon, 7 Mar 2016 19:43:40 +0000 (UTC) From: "Manikandan Subramanian (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Reopened] (HTTPCLIENT-1729) Evicting Stale connections from the connection pool MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikandan Subramanian reopened HTTPCLIENT-1729: ------------------------------------------------ > Evicting Stale connections from the connection pool > --------------------------------------------------- > > Key: HTTPCLIENT-1729 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1729 > Project: HttpComponents HttpClient > Issue Type: Bug > Affects Versions: 4.5.2 > Reporter: Manikandan Subramanian > Priority: Minor > Labels: newbie, performance > Fix For: 4.5.3 > > > This is not a bug. But more of a guidance needed here. > The below documentation suggests > https://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html > to use a separate monitor thread that calls closeExpiredConnections() method for stale connection handling. > Is this still applicable for 4.5.2 version as well ? I am looking at source code PoolingHttpClientConnectionManager#closeExpiredConnections which in turn calls the pool#closeExpired. > The closeExpired method checks only the expiration of the connections. However there seems to be no check on whether the connection is stale. > Should we still handle stale connections checks when using Apache HttpClient 4.5 ? What is the guidance here ? > Minor possible documentation issue > http://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.html > The above java doc claims that the default timeout that is used before a stale connection check is performed is 5000 ms. However the source code is setting the value to 2000ms. Please correct me if I am wrong. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org