Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 721C418975 for ; Fri, 19 Feb 2016 23:36:18 +0000 (UTC) Received: (qmail 6948 invoked by uid 500); 19 Feb 2016 23:36:18 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 6857 invoked by uid 500); 19 Feb 2016 23:36:18 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 6797 invoked by uid 99); 19 Feb 2016 23:36:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 23:36:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 14B942C1F5B for ; Fri, 19 Feb 2016 23:36:18 +0000 (UTC) Date: Fri, 19 Feb 2016 23:36:18 +0000 (UTC) From: "Gary Gregory (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HTTPCLIENT-1665) Regression in org.apache.http.entity.mime.MultipartEntity and org.apache.http.entity.mime.content.StringBody MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155143#comment-15155143 ] Gary Gregory edited comment on HTTPCLIENT-1665 at 2/19/16 11:35 PM: -------------------------------------------------------------------- I've applied your fix: {noformat} commit -m "[HTTPCLIENT-1665] Regression in org.apache.http.entity.mime.MultipartEntity and org.apache.http.entity.mime.content.StringBody. Use ASCII when charset is null." -N E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java Sending E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java Transmitting file data ... Committed revision 1731313. {noformat} Merci [~p.mouawad@ubik-ingenierie.com]! was (Author: garydgregory): I've applied this fix: {noformat} commit -m "[HTTPCLIENT-1665] Regression in org.apache.http.entity.mime.MultipartEntity and org.apache.http.entity.mime.content.StringBody. Use ASCII when charset is null." -N E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java Sending E:/vcs/svn/apache/httpcomponents/branches/4.5.x/httpclient/httpmime/src/main/java/org/apache/http/entity/mime/content/StringBody.java Transmitting file data ... Committed revision 1731313. {noformat} Merci [~p.mouawad@ubik-ingenierie.com]! > Regression in org.apache.http.entity.mime.MultipartEntity and org.apache.http.entity.mime.content.StringBody > -------------------------------------------------------------------------------------------------------------- > > Key: HTTPCLIENT-1665 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1665 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpMime > Affects Versions: 4.5 > Reporter: Philippe Mouawad > Priority: Trivial > Labels: regression > Fix For: 4.5.2 > > > As per org.apache.http.entity.mime.MultipartEntity constructor documentation: > > @param charset the character set to use, may be {@code null}, in which case {@link MIME#DEFAULT_CHARSET} - i.e. US-ASCII - is used. > But it appears that in 4.5 version, if null is passed then no charset part is written. > The same issue exists for FormBodyPart. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org