hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charlie Halford (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HTTPCLIENT-1725) Heuristic caching does not work for URIs with a query string
Date Mon, 29 Feb 2016 17:32:18 GMT
Charlie Halford created HTTPCLIENT-1725:
-------------------------------------------

             Summary: Heuristic caching does not work for URIs with a query string
                 Key: HTTPCLIENT-1725
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1725
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpCache
    Affects Versions: 4.5.1
            Reporter: Charlie Halford


When enabling heuristic caching and setting a default lifetime, the responses from the server
I am requesting from are not being stored in the cache.

In org.apache.http.impl.client.cache.ResponseCachingPolicy, line 250 determines if the URI
contains a query string:

{code}
request.getRequestLine().getUri().contains("?")
{code}

A few lines below, it then checks to see if the response contains cache headers:

{code}
else if (!isExplicitlyCacheable(response))
{code}

As I am attempting to cache a response that I know does not contain cache headers, the response
should succeed in being cached. However, it fails the isExplictlyCachable() check, and thus
returns false to the overall isResponseCachable() method. The isExplicitlyCachable() method
is checked later on in the stack, so perhaps it can be safely removed here?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message