hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "munene kiruja (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1718) OSGiCredentialsProvider.java compares the Authscope by .equals() instead of .match()
Date Tue, 16 Feb 2016 17:44:18 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15148973#comment-15148973
] 

munene kiruja commented on HTTPCLIENT-1718:
-------------------------------------------

Hi Oleg, That¹s right. Things got a bit interesting and confusing because
the at last merge, the pull request was not closed, and I checked in the
new before I realized that. Also perhaps because the merge was done to a
branch - I think 4.5.2, Git insisted on including the HTTPCLIENT-1710
changes in the new pull request again. Pardon me for the mess, I¹m still
growing my github skillz.
Thanks for all the work you do to keep the wheels turning.
Best Regards,
munene





> OSGiCredentialsProvider.java compares the Authscope by .equals() instead of .match()
 
> --------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1718
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1718
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.4.1, 5.0 Alpha1
>            Reporter: munene kiruja
>             Fix For: 4.5.2
>
>
> As a result, nothing can pass the comparison. The match function provide a wighted matching
based on which fields are matching and is perhaps the best to use to obtain the credentials
of the specified proxy from the configuration. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message