hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1665) Regression in org.apache.http.entity.mime.MultipartEntity and org.apache.http.entity.mime.content.StringBody
Date Fri, 19 Feb 2016 23:00:19 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155081#comment-15155081
] 

Gary Gregory commented on HTTPCLIENT-1665:
------------------------------------------

Hm, the {{StringBody}} ctor will use {{US-ASCII}}:

{code:java}
    public StringBody(final String text, final ContentType contentType) {
        super(contentType);
        Args.notNull(text, "Text");
        final Charset charset = contentType.getCharset();
        this.content = text.getBytes(charset != null ? charset : StandardCharsets.US_ASCII);
    }
{code}

> Regression in org.apache.http.entity.mime.MultipartEntity and   org.apache.http.entity.mime.content.StringBody
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1665
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1665
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpMime
>    Affects Versions: 4.5
>            Reporter: Philippe Mouawad
>            Priority: Trivial
>              Labels: regression
>             Fix For: 4.5.2
>
>
> As per org.apache.http.entity.mime.MultipartEntity constructor documentation:
> > @param charset the character set to use, may be {@code null}, in which case {@link
MIME#DEFAULT_CHARSET} - i.e. US-ASCII - is used.
> But it appears that in 4.5 version, if null is passed then no charset part is written.
> The same issue exists for  FormBodyPart.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message