Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 46DAE181A5 for ; Tue, 26 Jan 2016 21:40:40 +0000 (UTC) Received: (qmail 35874 invoked by uid 500); 26 Jan 2016 21:40:40 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 35809 invoked by uid 500); 26 Jan 2016 21:40:40 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 35777 invoked by uid 99); 26 Jan 2016 21:40:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 21:40:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E43B12C1F69 for ; Tue, 26 Jan 2016 21:40:39 +0000 (UTC) Date: Tue, 26 Jan 2016 21:40:39 +0000 (UTC) From: "Ralph Goers (JIRA)" To: dev@hc.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HTTPCLIENT-1715) NTLMEngineImpl.Type1Message not thread safe but declared as a constant MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118098#comment-15118098 ] Ralph Goers commented on HTTPCLIENT-1715: ----------------------------------------- Where can I find the code to look at? > NTLMEngineImpl.Type1Message not thread safe but declared as a constant > ---------------------------------------------------------------------- > > Key: HTTPCLIENT-1715 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1715 > Project: HttpComponents HttpClient > Issue Type: Bug > Components: HttpClient > Affects Versions: 4.5.1 > Reporter: Olivier Lafontaine > > {{NTLMEngineImpl}} declares a {{static final}} member named {{TYPE_1_MESSAGE}} of type {{Type1Message}}. Members of {{Type1Message}} are final and do not change, but that is not the case for members of its superclass {{NTLMMessage}}. > Whenever the method {{NTLMEngineImpl#getType1Message(String, String)}} is called, the method {{NTLMMessage#getResponse()}} get called on the {{TYPE_1_MESSAGE}} instance and this modifies the following members of {{NTLMMessage}}: > * messageContents > * currentOutputPosition > This is not thread safe and we get exceptions as seen in HTTPCLIENT-1686. > My guess is that the computed response string should be kept in a constant instead of a {{Type1Message}} instance. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org